teamspeak_client: Re-link with qt 5.9 #33863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
25 tasks
|
Sorry I totally forgot this PR I will try it soon 👍 |
|
The commit works for me :) (with qt 5.10) |
|
Works for me too 👍 |
|
Thanks for testing 👍 |
|
Thanks for updating and testing this.
I don't really use this package any more so it's pretty low on my list of
priorities. If anyone else wants to pick up maintenance then go for it.
Cheers,
Nathaniel Baxter
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
See #33798
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)Tested starting the application and clicking around the UI a bit and it seems to work fine.
cc @bkchr @DeltaEvo @nathanielbaxter