Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

llvm-5: add extra 'python' output for opt-viewer tool #33871

Merged
merged 1 commit into from Feb 6, 2018
Merged

llvm-5: add extra 'python' output for opt-viewer tool #33871

merged 1 commit into from Feb 6, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 14, 2018

#33374 (review)

We don't really support the opt-viewer tool anyway,
but keep it around in case someone wants to play with it.

Don't pull python into the closure just for that reason, though.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill changed the base branch from master to staging January 14, 2018 22:54
@vcunat
Copy link
Member

vcunat commented Jan 14, 2018

Sounds OK to me.

@dtzWill
Copy link
Member Author

dtzWill commented Jan 17, 2018

We could alternatively delete it, but saving it to an extra output seems a bit kinder :).

Eventually we can try wrapping it or something to get it working, but mostly want to fix Darwin closure with LLVM 5.

LnL7
LnL7 approved these changes Jan 31, 2018
View reviewed changes
Copy link
Member

@LnL7 LnL7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in principle, testing if this helps with the stdenv references.

@LnL7 LnL7 mentioned this pull request Feb 1, 2018
Merged
8 tasks
@dtzWill
Copy link
Member Author

dtzWill commented Feb 2, 2018 •
edited

@LnL7 we have a "success" regarding this resolving the references problem right?

I suppose there's no rush motivating merging this separately from #33374, but just checking :).

EDIT: Conflict resolution underway... done!

@LnL7 LnL7 merged commit 335ae38 into NixOS:staging Feb 6, 2018
dtzWill added a commit to dtzWill/nixpkgs that referenced this pull request Mar 8, 2018
@dtzWill
llvm6: same python output fix from NixOS#33871
11cb7d0 
Unlike that PR, however, this doesn't need to go to staging
since no one depends on a package that doesn't exist yet :).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@FRidh FRidh Awaiting requested review from FRidh

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dtzWill @vcunat @LnL7 @GrahamcOfBorg