Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rofi: 1.4.2 -> 1.5.0 #34519

Closed
wants to merge 3 commits into from
Closed

rofi: 1.4.2 -> 1.5.0 #34519

wants to merge 3 commits into from

Conversation

matthiasbeyer
Copy link
Contributor

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Does not build on my machine... though I have no time to investigate right now.

Feel free to reuse this patch.

@matthiasbeyer
Copy link
Contributor Author

btw: Building fails because one test fails.

@andir
Copy link
Member

andir commented Feb 2, 2018

@GrahamcOfBorg build rofi

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

  "_strchrnul", referenced from:
      _combi_mode_result in rofi-combi.o
      _combi_preprocess_input in rofi-combi.o
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:2091: rofi] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make: *** [Makefile:1694: all] Error 2
builder for '/nix/store/rl2ljwrfy1hhs97if3q2mi5hpv1sd8gg-rofi-1.5.0.drv' failed with exit code 2
error: build of '/nix/store/rl2ljwrfy1hhs97if3q2mi5hpv1sd8gg-rofi-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:4495: test-suite.log] Error 1
make[3]: Leaving directory '/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make[2]: *** [Makefile:4603: check-TESTS] Error 2
make[2]: Leaving directory '/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make[1]: *** [Makefile:4883: check-am] Error 2
make[1]: Leaving directory '/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make: *** [Makefile:4885: check] Error 2
builder for ‘/nix/store/45iwhbp0swgx6m9c2shbr58gylldss0q-rofi-1.5.0.drv’ failed with exit code 2
error: build of ‘/nix/store/45iwhbp0swgx6m9c2shbr58gylldss0q-rofi-1.5.0.drv’ failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:4495: test-suite.log] Error 1
make[3]: Leaving directory '/build/rofi-1.5.0'
make[2]: *** [Makefile:4603: check-TESTS] Error 2
make[2]: Leaving directory '/build/rofi-1.5.0'
make[1]: *** [Makefile:4883: check-am] Error 2
make[1]: Leaving directory '/build/rofi-1.5.0'
make: *** [Makefile:4885: check] Error 2
builder for '/nix/store/5jd89gq497knggvj3nnwz9ik0vk4nvhg-rofi-1.5.0.drv' failed with exit code 2
error: build of '/nix/store/5jd89gq497knggvj3nnwz9ik0vk4nvhg-rofi-1.5.0.drv' failed

@andir
Copy link
Member

andir commented Feb 2, 2018

nitpick: The URL is outdated. If you visit the homepage noted in the meta attributes then you will be greeted with a deprecation warning and shortly after that redirected to the GitHub repository.

So far I suspect the reason the (gtk settings) test is failing to be because our sandboxed builders do not have a proper $HOME? I'll try to investigate further soon.

@teto
Copy link
Member

teto commented Feb 2, 2018

changelog for the curious https://github.com/DaveDavenport/rofi/blob/next/Changelog

@Mic92
Copy link
Member

Mic92 commented Feb 10, 2018

@GrahamcOfBorg build rofi

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:4495: test-suite.log] Error 1
make[3]: Leaving directory '/build/rofi-1.5.0'
make[2]: *** [Makefile:4603: check-TESTS] Error 2
make[2]: Leaving directory '/build/rofi-1.5.0'
make[1]: *** [Makefile:4883: check-am] Error 2
make[1]: Leaving directory '/build/rofi-1.5.0'
make: *** [Makefile:4885: check] Error 2
builder for '/nix/store/d3vnvl6r5ml22f4scidagrz516cmhbq7-rofi-1.5.0.drv' failed with exit code 2
error: build of '/nix/store/d3vnvl6r5ml22f4scidagrz516cmhbq7-rofi-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:4495: test-suite.log] Error 1
make[3]: Leaving directory '/build/rofi-1.5.0'
make[2]: *** [Makefile:4603: check-TESTS] Error 2
make[2]: Leaving directory '/build/rofi-1.5.0'
make[1]: *** [Makefile:4883: check-am] Error 2
make[1]: Leaving directory '/build/rofi-1.5.0'
make: *** [Makefile:4885: check] Error 2
builder for '/nix/store/0jbkmrx5r5cba2aj2m3bc05ypn8yfrha-rofi-1.5.0.drv' failed with exit code 2
error: build of '/nix/store/0jbkmrx5r5cba2aj2m3bc05ypn8yfrha-rofi-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

  "_strchrnul", referenced from:
      _combi_mode_result in rofi-combi.o
      _combi_preprocess_input in rofi-combi.o
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:2091: rofi] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make: *** [Makefile:1694: all] Error 2
builder for '/nix/store/gcnyxq484vgma86hj1vnzrlgvxxza102-rofi-1.5.0.drv' failed with exit code 2
error: build of '/nix/store/gcnyxq484vgma86hj1vnzrlgvxxza102-rofi-1.5.0.drv' failed

@matthiasbeyer
Copy link
Contributor Author

@GrahamcOfBorg build rofi

1 similar comment
@andir
Copy link
Member

andir commented Feb 14, 2018

@GrahamcOfBorg build rofi

@GrahamcOfBorg
Copy link

Failure on x86_64-darwin (full log)

Partial log (click to expand)

  "_strchrnul", referenced from:
      _combi_mode_result in rofi-combi.o
      _combi_preprocess_input in rofi-combi.o
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [Makefile:2091: rofi] Error 1
make[1]: Leaving directory '/private/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make: *** [Makefile:1694: all] Error 2
builder for '/nix/store/4asvwsavsfvrndc7bdpzk4va650613k6-rofi-1.5.0.drv' failed with exit code 2
error: build of '/nix/store/4asvwsavsfvrndc7bdpzk4va650613k6-rofi-1.5.0.drv' failed

@GrahamcOfBorg
Copy link

Failure on x86_64-linux (full log)

Partial log (click to expand)

============================================================================
make[3]: *** [Makefile:4495: test-suite.log] Error 1
make[3]: Leaving directory '/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make[2]: *** [Makefile:4603: check-TESTS] Error 2
make[2]: Leaving directory '/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make[1]: *** [Makefile:4883: check-am] Error 2
make[1]: Leaving directory '/tmp/nix-build-rofi-1.5.0.drv-0/rofi-1.5.0'
make: *** [Makefile:4885: check] Error 2
builder for ‘/nix/store/2aqdv5fy9razqym1qx5xy9033ml0nzrm-rofi-1.5.0.drv’ failed with exit code 2
error: build of ‘/nix/store/2aqdv5fy9razqym1qx5xy9033ml0nzrm-rofi-1.5.0.drv’ failed

@matthiasbeyer
Copy link
Contributor Author

I don't even understand what the error is...

and why does github say "All checks have passed" despite the bot failing?

@andir
Copy link
Member

andir commented Feb 14, 2018

The @GrahamcOfBorg builds are not part of the normal github checks.

The Mac build most likely fails because some Mac specific library isn't being linked.. I doubt the previous versions did build there.

@GrahamcOfBorg
Copy link

Failure on aarch64-linux (full log)

Partial log (click to expand)

   Compiling unwind v0.0.0 (file:///build/rustc-1.22.1-src/src/libunwind)
   Compiling cc v1.0.0
   Compiling libc v0.2.31
   Compiling filetime v0.1.12
   Compiling build_helper v0.1.0 (file:///build/rustc-1.22.1-src/src/build_helper)
building of '/nix/store/1vbyjba76gw7jcs9g5sqyb2bxsb0xpln-rustc-1.22.1.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/wjjfbzq8gfxgbd3f426j8syljcqjdsk1-cargo-0.23.0.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/bvngc1qvckx0cm4lbcvjalnzi4bdy4dz-librsvg-2.42.2.drv': 2 dependencies couldn't be built
cannot build derivation '/nix/store/28zfjak7wajhpppyijlq9vr9g2nbcs0v-rofi-1.5.0.drv': 1 dependencies couldn't be built
error: build of '/nix/store/28zfjak7wajhpppyijlq9vr9g2nbcs0v-rofi-1.5.0.drv' failed

@Mic92
Copy link
Member

Mic92 commented Feb 15, 2018

According to the logs on x86_64 one test fails.

@andir
Copy link
Member

andir commented Feb 15, 2018

Yes ,that is the "subprojects/libnkutils/tests/gtk-settings.test" which was introcuded with this bump IIRC.

It probably assumes the ability to write to $HOME which might not be writable during test execution/at all?

@7c6f434c
Copy link
Member

Well, $HOME can be set to something inside the build directory before running the tests.

@7c6f434c
Copy link
Member

Maybe the test requires X? I guess we generally just disable such tests, although in principle xdummy could be an option.

@Mic92
Copy link
Member

Mic92 commented Feb 23, 2018

Maybe try this?
preConfigure = "export HOME=$(mktemp -d)"

@matthiasbeyer
Copy link
Contributor Author

With the change suggested by @Mic92 this fails still:

FAIL: subprojects/libnkutils/tests/gtk-settings
===============================================

/nkutils/gtk-settings/4.0/boolean: **
ERROR:subprojects/libnkutils/tests/gtk-settings.c:100:_nk_gtk_settings_tests_func: 'ret' should be TRUE
FAIL
/nkutils/gtk-settings/4.0/uint64: **
ERROR:subprojects/libnkutils/tests/gtk-settings.c:112:_nk_gtk_settings_tests_func: 'ret' should be TRUE
**
ERROR:subprojects/libnkutils/tests/gtk-settings.c:113:_nk_gtk_settings_tests_func: assertion failed (value == data->value.int64): (3530962845198832513 == 300)
FAIL
/nkutils/gtk-settings/4.0/string: **
ERROR:subprojects/libnkutils/tests/gtk-settings.c:121:_nk_gtk_settings_tests_func: 'ret' should be TRUE
FAIL subprojects/libnkutils/tests/gtk-settings.test (exit status: 139)

Homepage updated, though.

@lukateras
Copy link
Member

Superseded by 7c4886d, c7adb9d.

@lukateras lukateras closed this Oct 13, 2018
@matthiasbeyer matthiasbeyer deleted the update-rofi branch October 13, 2018 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
2.status: work-in-progress 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@matthiasbeyer @andir @GrahamcOfBorg @teto @Mic92 @7c6f434c @lukateras @matthewbauer