Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixops-dns: init at f6c3f79 #34510

Merged
merged 1 commit into from Feb 10, 2018
Merged

nixops-dns: init at f6c3f79 #34510

merged 1 commit into from Feb 10, 2018

Conversation

sorki
Copy link
Member

@sorki sorki commented Feb 2, 2018

Motivation for this change

Easy DNS resolution for nixops vms.

CC @kamilchm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@sorki sorki mentioned this pull request Feb 2, 2018
Merged
8 tasks
kamilchm
kamilchm reviewed Feb 2, 2018
View reviewed changes
pkgs/tools/package-management/nixops/nixops-dns.nix Outdated
name = "nixops-dns";
version = "HEAD";

goDeps = ./deps.nix;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is deps.nix missing in the pr?
I can also vendor deps in nixops-dns repo so we don't need it here. Which way do you prefer?

@sorki
Copy link
Member Author

sorki commented Feb 2, 2018

There it is. I'm not sure which way is better.

kamilchm
kamilchm reviewed Feb 2, 2018
View reviewed changes
pkgs/tools/package-management/nixops/nixops-dns.nix Outdated

buildGoPackage rec {
name = "nixops-dns";
version = "HEAD";
Copy link
Member

@kamilchm kamilchm Feb 2, 2018 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tagged it with v1.0 https://github.com/kamilchm/nixops-dns/releases/tag/v1.0 to make it look better

@Mic92 Mic92 merged commit df0fe7a into NixOS:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kamilchm kamilchm kamilchm approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@sorki @kamilchm @Mic92 @GrahamcOfBorg