Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tasknc: update (0.8 -> 2017-05-15), fix, cleanup and man pages #34520

Merged
merged 1 commit into from Feb 10, 2018

Conversation

infinisil
Copy link
Member

Motivation for this change

tasknc has been broken for some reason for as long as I can remember, segfaulting at the start. man pages were not available either.

This commit updates tasknc to the most recent version which contains some fixes. Made the manpages work (also removes the makefile hack). Cleaned up dependencies (fixed the taskwarrior dependency, it's a runtime one. Also some nativeBuildInputs stuff). Apparently tasknc changed owners, so I got that changed too.

Ping @matthiasbeyer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member Author

This probably should be backported to 17.09, since the version there currently doesn't work at all

Copy link
Contributor

@matthiasbeyer matthiasbeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work! Also nice that you added yourself to the maintainers, thanks for that!

@Mic92 Mic92 merged commit e2a2751 into NixOS:master Feb 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants