Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made Zig support tabs #734

Closed
wants to merge 1 commit into from
Closed

Made Zig support tabs #734

wants to merge 1 commit into from

Conversation

zesterer
Copy link

@zesterer zesterer commented Feb 2, 2018

I'd say this is a fairly common sense thing to do. Whitespace styles have no effect on identifier names or anything else that could alter compatibility between different pieces of Zig code. It's also something that's incredibly easy to alter after the code is written: just put the code through a formatter and you're done. Besides, there are reasonable reasons for using both spaces and tabs for indenting: it's not as if one is objectively better than another. Compiler errors should be reserved for things that are objectively incorrect or have the ability to produce compatibility problems (such as non-standard case in public identifier names), not superficial styling choices.

@andrewrk
Copy link
Member

andrewrk commented Feb 2, 2018

Thanks for the PR. Discussion in #544

@andrewrk andrewrk closed this Feb 3, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants