Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fastlane: -> 2.79.0 #34513

Closed
wants to merge 1 commit into from
Closed

fastlane: -> 2.79.0 #34513

wants to merge 1 commit into from

Conversation

peterromfeldhk
Copy link
Contributor

@peterromfeldhk peterromfeldhk commented Feb 2, 2018 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

infinisil commented Feb 2, 2018 •
edited

You seem to be branching off an older revision, fastlane has been updated to 2.75.1 in 828298c Please rebase on a newer revision to not have any merge conflicts

Also the commit message is missing the <from> version

@peterromfeldhk
Copy link
Contributor Author

ill reopen after fix (easier to just do run the update script again from correct branch then try to fix this)

@peterromfeldhk peterromfeldhk deleted the fastlane branch February 5, 2018 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@peterromfeldhk @infinisil