Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tiled: 1.1.1 -> 1.1.2 #34516

Merged
merged 1 commit into from Feb 3, 2018
Merged

tiled: 1.1.1 -> 1.1.2 #34516

merged 1 commit into from Feb 3, 2018

Conversation

dywedir
Copy link
Member

@dywedir dywedir commented Feb 2, 2018

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member

As already mentioned in #26829 (@Mic92 @ttuegel), this still fails in the same way if you don't have qt installed:

This application failed to start because it could not find or load the Qt platform plugin "xcb"
in "".
Reinstalling the application may fix this problem.
[1]    29246            result/bin/tiled

Is this a known qt issue or can this be avoided? Packages in nixpkgs should bring all dependencies with them.

@ttuegel
Copy link
Member

ttuegel commented Feb 2, 2018

Packages in nixpkgs should bring all dependencies with them.

That would be nice, but it's not the Nixpkgs policy. Qt packages do not work unless installed. This is a documented trade-off of the current design. The trade-off is: do applications work correctly when installed, or when run from the Nix store? The unfortunate decision by Qt to make everything a plugin makes it impossible to correctly support both. I am working on changes to make the trade-off more fine-grained. Ultimately, that will allow us to trade this problem for another.

@FRidh FRidh merged commit 9261f3b into NixOS:master Feb 3, 2018
@dywedir dywedir deleted the tiled branch February 3, 2018 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dywedir @infinisil @ttuegel @FRidh @GrahamcOfBorg