Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ckb: 0.2.8 -> 0.2.9 + project moved #34142

Merged
merged 1 commit into from Jan 23, 2018
Merged

Conversation

Nadrieril
Copy link
Member

Motivation for this change

The ckb project owner was unreachable (see #33286) so the community has now organized itself around a github community instead and moved the project.
They has also made a new release.

This PR also includes a patch to fix a missing dependency (closes #33287).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build ckb

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘ckb-next-0.2.9’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/tools/misc/ckb/default.nix:46 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9/libexec/ckb-animations/ckb-rain
shrinking /nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9/libexec/ckb-animations/ckb-random
shrinking /nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9/libexec/ckb-animations/ckb-heat
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9/libexec  /nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9/bin 
patching script interpreter paths in /nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9
checking for references to /tmp/nix-build-ckb-next-0.2.9.drv-0 in /nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9...
postPatchMkspecs
postPatchMkspecs
/nix/store/5202aplw7argr4jc00mk95vy200c7y16-ckb-next-0.2.9

@7c6f434c
Copy link
Member

I think homepage should also be updated.

@kierdavis
Copy link
Contributor

@Nadrieril thanks for this. The modprobe PR (#33287) has just been merged (I bumped the issue in IRC), so it shouldn't be necessary to include the changes in this PR anymore.

Somewhat relatedly, I'm not usually a fan of PRs that combine many changes into one - in particular because the modprobe patch had already been reviewed and was ready for merged. I do agree however that it felt like things were moving quite slowly; I suppose the repo maintainers likely just have their hands full at the moment.

Back on topic, I've tested this PR on my system with no problems. Though as @7c6f434c suggests it would be good to point the homepage URL at the new location of ckb-next.

@Nadrieril
Copy link
Member Author

You're right, apologies for trying to force the modprobe patch, I was impatient.
I updated the homepage and rebased on top of master.

@adisbladis adisbladis merged commit 9c534ca into NixOS:master Jan 23, 2018
@kierdavis
Copy link
Contributor

@Nadrieril no worries, thanks!

@Nadrieril Nadrieril deleted the update-ckb branch February 10, 2018 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants