Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.yarl: 1.0.0 -> 1.1.0 #34147

Merged
merged 1 commit into from Jan 23, 2018
Merged

python3Packages.yarl: 1.0.0 -> 1.1.0 #34147

merged 1 commit into from Jan 23, 2018

Conversation

dotlambda
Copy link
Member

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dotlambda dotlambda requested a review from FRidh as a code owner January 22, 2018 16:12
rasendubi
rasendubi approved these changes Jan 23, 2018
View reviewed changes
Copy link
Member

@rasendubi rasendubi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would you like to become the maintainer of the package?

@dotlambda
Copy link
Member Author

I could do that, even though I have never used the package. I just need the newer version for #33675.

@adisbladis
Copy link
Member

@GrahamcOfBorg eval

@adisbladis
Copy link
Member

@dotlambda I fixed your eval issue (maintainers was not scoped). Thanks!

@adisbladis adisbladis merged commit 70cf5ea into NixOS:master Jan 23, 2018
@dotlambda dotlambda deleted the yarl branch February 8, 2018 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rasendubi rasendubi rasendubi approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@dotlambda @adisbladis @rasendubi @GrahamcOfBorg