Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch/sgrouphydrogens #411

Merged
merged 7 commits into from Jan 14, 2018
Merged

Patch/sgrouphydrogens #411

merged 7 commits into from Jan 14, 2018

Conversation

johnmay
Copy link
Member

@johnmay johnmay commented Jan 13, 2018

From discussion cdk/depict#7... refine hydrogen suppression context.

egonw
egonw approved these changes Jan 13, 2018
View reviewed changes
Copy link
Member

@egonw egonw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just three useless observations. Is there a need to add a dedicated test for the manipulator?

base/core/src/main/java/org/openscience/cdk/sgroup/Sgroup.java
@@ -114,14 +114,22 @@ public final SgroupType getType() {
}

/**
* Add a bond to this Sgroup.
* Add an atom to this Sgroup.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow... so much for peer review.

base/core/src/main/java/org/openscience/cdk/tools/manipulator/SgroupManipulator.java
@@ -0,0 +1,114 @@
/*
* Copyright (c) 2018 John Mayfield
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, the yearly README update :)

base/core/src/main/java/org/openscience/cdk/tools/manipulator/SgroupManipulator.java Outdated
}

/**
* Copy a collection of Sgroups, replacing any IAtom/IBond (ChemObject)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Option to use {@link}...

@johnmay
Copy link
Member Author

johnmay commented Jan 14, 2018

Added dedicated tests

@egonw egonw merged commit 7d2c854 into master Jan 14, 2018
@johnmay johnmay deleted the patch/sgrouphydrogens branch March 18, 2018 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@egonw egonw egonw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@johnmay @egonw