Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-lint: fix #33809

Closed
wants to merge 1 commit into from
Closed

nixpkgs-lint: fix #33809

wants to merge 1 commit into from

Conversation

infinisil
Copy link
Member

Motivation for this change

Gave runtime error before

Note that while it runs with this change, it throws a warning at runtime because the variable drvPath isn't defined in this line: https://github.com/NixOS/nixpkgs/blob/master/maintainers/scripts/nixpkgs-lint.pl#L151. My perl is insufficient to decipher the meaning of this line and how to get rid of the warning.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@infinisil
Copy link
Member Author

Update: not broken after all

@infinisil infinisil closed this Jan 12, 2018
@infinisil
Copy link
Member Author

The -a means to query available packages (with a regex), it's not supposed to mean -A which would mean to query an attribute.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants