Add overload to String.from_utf16 with pointer #5583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
straight-shoota
force-pushed
the
jm/string-from-utf16-pointer
branch
from
b7e03e1
to
82ea8cc
Compare
asterite
approved these changes
Jan 13, 2018
src/string/utf16.cr
Outdated
| # ``` | ||
| # slice = Slice[104_u16, 105_u16, 32_u16, 0_u16, 55296_u16, 56485_u16] | ||
| # String.from_utf16(slice) # => "hi \0000𐂥" | ||
| # String.from_utf16(slice.to_unsafe) # => "hi" |
There was a problem hiding this comment.
I think the result is missing a space
src/string/utf16.cr
Outdated
| @@ -53,7 +53,15 @@ class String | |||
| # slice = Slice[104_u16, 105_u16, 32_u16, 55296_u16, 56485_u16] | |||
| # String.from_utf16(slice) # => "hi 𐂥" | |||
| # ``` | |||
| def self.from_utf16(slice : Slice(UInt16)) : String | |||
| # | |||
| # If *slice* is a pointer, the string is interpreted as null-terminated. | |||
There was a problem hiding this comment.
The input pointer could be interpreted as a string, but maybe it's better to say that it ends when a value of zero is found?
straight-shoota
force-pushed
the
jm/string-from-utf16-pointer
branch
from
82ea8cc
to
d7d75a8
Compare
RX14
approved these changes
Jan 13, 2018
|
merge? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows handling null-terminated wchar strings.