nextcloud-client: fix icon name in desktop file #33827
Merged
+4
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
The desktop file bundled with nextcloud calls the icon
nextcloud
, but theicons are named
Nextcloud
and so desktop environments won't find it.Note that upstream uses the opposite workaround in their appimage creation script (renaming an icon file to match what the desktop file expects): https://github.com/nextcloud/client_theming/blob/d0a46ea2f04eb9fe1b99d4cedfb595bc7664d27f/linux/AppImage/build-appimage.sh#L61
I'm using the capture group to find matching lines because the translations generate lines like
Icon[ja_JP]=nextcloud
and those need to be changed too.Things done
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)