Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nextcloud-client: fix icon name in desktop file #33827

Merged
merged 1 commit into from Feb 17, 2018

Conversation

eqyiel
Copy link
Contributor

@eqyiel eqyiel commented Jan 13, 2018

Motivation for this change

The desktop file bundled with nextcloud calls the icon nextcloud, but the
icons are named Nextcloud and so desktop environments won't find it.

Note that upstream uses the opposite workaround in their appimage creation script (renaming an icon file to match what the desktop file expects): https://github.com/nextcloud/client_theming/blob/d0a46ea2f04eb9fe1b99d4cedfb595bc7664d27f/linux/AppImage/build-appimage.sh#L61

I'm using the capture group to find matching lines because the translations generate lines like Icon[ja_JP]=nextcloud and those need to be changed too.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

The desktop file bundled with nextcloud calls the icon `nextcloud`, but the
icons are named `Nextcloud` and so desktop environments won't find it.
@joachifm joachifm merged commit e18b4e8 into NixOS:master Feb 17, 2018
@eqyiel eqyiel deleted the nextcloud-client-icon-fix branch February 18, 2018 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants