Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

release-small: Don't attempt to access "dbus.libs", etc., don't exist #33811

Merged
merged 1 commit into from Jan 16, 2018
Merged

release-small: Don't attempt to access "dbus.libs", etc., don't exist #33811

merged 1 commit into from Jan 16, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 13, 2018

dbus_libs and others do, but they're deprecated.

Just build 'dbus', these are now its various outputs.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@dtzWill
release-small: Don't attempt to access "dbus.libs", etc., don't exist
5911b8d 
dbus_libs and others do, but they're deprecated.

Just build 'dbus', these are now its various outputs.
@dtzWill
Copy link
Member Author

dtzWill commented Jan 16, 2018

Actually maybe we should remove this file entirely. Looks like nothing uses it, which explains how this wasn't fixed already.

As it is, causes hydra evaluation error which isn't a huge deal but annoying since it's no longer easy to spot if I broke evaluation or if its just the "expected" set of evaluation errors.

@vcunat
Copy link
Member

vcunat commented Jan 16, 2018

If you're interested in getting rid of the "expected" evaluation errors, that should now be possible on master via config.handleEvalIssue.

@vcunat vcunat merged commit 5911b8d into NixOS:master Jan 16, 2018
vcunat added a commit that referenced this pull request Jan 16, 2018
@vcunat
Merge #33811: nixpkgs release-small: fix evaluation
03c6be8
@dtzWill dtzWill deleted the fix/release-small-dbus-libs branch January 16, 2018 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @vcunat @GrahamcOfBorg