aenum: make tests pass #33805
Merged
aenum: make tests pass #33805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For Python 2, tests were failing because they depended on a particular way of executing the tests module as it defined a global variable and created a temporary file. Running it through setup.py didn't work. Invoking it directly solved the issue. For Python 3, aenum tests were disabled, however, they did't have to fail. Configuring UTF8 locale resolved the failure that was happening after the above fix for Python 2 was applied.
Mic92
reviewed
Jan 13, 2018
|
|
||
| checkPhase = '' | ||
| runHook preCheck | ||
| ${if isPy3k then "export LC_ALL=en_US.UTF-8" else ""} |
There was a problem hiding this comment.
You can export this unconditionally. It won't hurt on python2.
There was a problem hiding this comment.
Yeah, I get that. The reason to do it this way was to be more indicative of the fact that this tweak is ONLY necessary on Python 3 and avoid signalling that maybe Python 2 requires that, too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Python 2, tests were failing because they depended on a particular
way of executing the tests module as it defined a global variable
and created a temporary file. Running it through setup.py didn't work.
Invoking it directly solved the issue.
For Python 3, aenum tests were disabled, however, they did't have to
fail. Configuring UTF8 locale resolved the failure that was happening
after the above fix for Python 2 was applied.
Motivation for this change
Couldn't build another derivation that had to depend on aenum, even on Python 2, as the tests were failing.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)I tried to use
nox-review wip, however, I got a failure on thedbfderivation, however, at least for me, buildingdbffails for Python 2.7 on master nixpkgs anyway (becauseaenum's tests fail). Any advice on this will be highly appreciated.cc @vrthra