Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

services.mysql: properly quote database.name #33821

Merged
merged 1 commit into from Feb 8, 2018
Merged

services.mysql: properly quote database.name #33821

merged 1 commit into from Feb 8, 2018

Conversation

yurrriq
Copy link
Member

@yurrriq yurrriq commented Jan 13, 2018 •
edited

Motivation for this change

Address the quoting issues discussed on #5227.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review 33821"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@yurrriq
Copy link
Member Author

yurrriq commented Jan 13, 2018

/cc @Profpatsch

@Profpatsch
Copy link
Member

According to https://stackoverflow.com/questions/11321491/when-to-use-single-quotes-double-quotes-and-backticks-in-mysql, backticks should be used to quote identifiers that might be the same as reserved keywords, so +1 from me.

@yurrriq
Copy link
Member Author

yurrriq commented Feb 8, 2018

Can someone please merge?

@Profpatsch Profpatsch merged commit 6b45dbd into NixOS:master Feb 8, 2018
@Profpatsch
Copy link
Member

Thanks.

@yurrriq
Copy link
Member Author

yurrriq commented Feb 8, 2018

Thank you!

@srhb srhb mentioned this pull request Feb 20, 2018
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yurrriq @Profpatsch @GrahamcOfBorg