Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

google-chrome: add dependency on kerberos #33706

Merged
merged 1 commit into from Feb 17, 2018
Merged

google-chrome: add dependency on kerberos #33706

merged 1 commit into from Feb 17, 2018

Conversation

catern
Copy link
Contributor

@catern catern commented Jan 10, 2018

Without this, Chrome doesn't work with websites requiring Kerberos
authentication.

Motivation for this change

I want to use websites requiring Kerberos authentication

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@catern
google-chrome: add dependency on kerberos
413cb93 
Without this, Chrome doesn't work with websites requiring Kerberos
authentication.
@catern
Copy link
Contributor Author

catern commented Jan 25, 2018

@msteen ping?

@msteen
Copy link
Contributor

msteen commented Jan 25, 2018

I just rebuild my Google Chrome package with this change and it still works fine on my NixOS install. I have not tested kerberos though, I have never used it, so I will just that @catern has tested it succesfully before submitting this pull request. I also checked the Chromium package and saw that it already includes the kerberos dependency, so it really ought to also be in the Google Chrome package. So if anyone with merge rights can merge this pull request, that would be appreciated.

@joachifm joachifm merged commit d5e342e into NixOS:master Feb 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@catern @msteen @joachifm @GrahamcOfBorg