Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

callCabal2nix: Use cleanSourceWith for composable filtering #33712

Merged
merged 1 commit into from Jan 11, 2018
Merged

callCabal2nix: Use cleanSourceWith for composable filtering #33712

merged 1 commit into from Jan 11, 2018

Conversation

shlevy
Copy link
Member

@shlevy shlevy commented Jan 10, 2018

No description provided.

@shlevy shlevy requested a review from peti January 10, 2018 17:47
@shlevy
Copy link
Member Author

shlevy commented Jan 10, 2018

cc @sellout , can you test this?

peti
peti reviewed Jan 10, 2018
View reviewed changes
Copy link
Member

@peti peti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Once someone has actually tested those changes, I'm in favor of merging.

@shlevy shlevy merged commit fb2b6ac into NixOS:master Jan 11, 2018
@shlevy shlevy deleted the callCabal2nix-cleanSourceWith branch January 11, 2018 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti peti left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shlevy @peti @GrahamcOfBorg