texlive: don't remove luatex from packages that require it. #33698
Conversation
Go for it! Still need to add some tests for Python constructs... |
|
(I may do so eventually, but separately since I don't think I'll get to it anytime soon) |
|
Moving to staging... |
|
Ping! Would like to get this in before 18.03, with plenty of time for testing any unintended consequences. Please :). |
|
cc @vcunat -- thoughts? |
|
Ping! |
|
@vcunat please acknowledge, even if only to say you can't review or need more time or whatever the case may be :). |
|
@dtzWill I'm sorry. I haven't been really following texlive tickets lately. I'm spread over much nix* stuff and TeX happens to be relatively low on my priority list. It had been different when I created this framework, as I was using LaTeX a lot, I had more time for nix*, our texlive was composed of large packages being fully rebuilt on every stdenv change, etc. I think it would be better if there was someone else willing to take over the maintainership. Closure size was certainly the motivation for this removal. Maybe the situation has changed since 2015, I don't know. Anyway, at a superficial look this seems OK, so feel free to merge (you probably know better than me from the brief look). |
|
Thank you very much for your response @vcunat, and for all you do! 👍 Part of the motivation for this PR is that in absence of large amounts of maintainer time it seems best to follow upstream for minimal surprises or breakage due to our modifications (unless there is a pressing reason to do otherwise, which I was unsure was the case). The rebuild frequency was not something I had considered--that is, if this adds dependencies to a number of packages how likely/frequently will large texlive packages need to be rebuilt? That is not something I'm sure how to answer reasonably. Hmm. |
|
Rebuild frequency isn't really relevant here. Almost all texlive are fixed-output derivations ;-) |
|
Oh, I thought our patching might make large things depend on say, lua, when they didn't previously. Hmm, then maybe this is good? 😁 Anyone you'd like to take a second look before going ahead with this? Thanks again! |
|
Well, there are smaller (not gigabytes) compiled "parts" of packages that are added, and those do have dependencies on non-tex packages. |
Fixes #31482.
Motivation for this change
Leaving other dependencies that we patch out into other collections, but keeping luatex since it is needed by at least
texlive-scriptswhich is part ofcollection-basic(which is foundation of many other collections).I'm not sure why it was not included in the first place--if it was closure size it appears that is not a significant concern, see #32661 (comment) for some numbers.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)PS I wish we had a place to dump things like Nix expressions that test "ensure this MWE still builds" or something. Soon, hopefully! :)