Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nodejs: 9.3.0 -> 9.4.0 #33707

Merged
merged 1 commit into from Jan 11, 2018
Merged

nodejs: 9.3.0 -> 9.4.0 #33707

merged 1 commit into from Jan 11, 2018

Conversation

frontsideair
Copy link
Contributor

@frontsideair frontsideair commented Jan 10, 2018

Motivation for this change

New upstream release.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@adisbladis
Copy link
Member

@GrahamcOfBorg build nodejs-9_x

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

  clang '-D_DARWIN_USE_64_BIT_INODE=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/zhza28rq3gy93lacp1xvz3dmk3ybpvi6-zlib-1.2.11-dev/include -I/nix/store/1ws18qwp1qr8fmjkawq54blddll4ngma-libuv-1.18.0/include -I/nix/store/aql117ic0q8syma8yl9y1gqnv244aqa5-openssl-1.0.2n-dev/include -I../deps/icu-small/source/common -I../deps/icu-small/source/i18n -I../deps/icu-small/source/tools/toolutil  -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/.deps//private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/obj.host/genccode/deps/icu-small/source/tools/genccode/genccode.o.d.raw   -c -o /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/obj.host/genccode/deps/icu-small/source/tools/genccode/genccode.o ../deps/icu-small/source/tools/genccode/genccode.c
  clang++ '-D_DARWIN_USE_64_BIT_INODE=1' '-DUCONFIG_NO_SERVICE=1' '-DUCONFIG_NO_REGULAR_EXPRESSIONS=1' '-DU_ENABLE_DYLOAD=0' '-DU_STATIC_IMPLEMENTATION=1' '-DU_HAVE_STD_STRING=0' '-DUCONFIG_NO_BREAK_ITERATION=0' -I/nix/store/zhza28rq3gy93lacp1xvz3dmk3ybpvi6-zlib-1.2.11-dev/include -I/nix/store/1ws18qwp1qr8fmjkawq54blddll4ngma-libuv-1.18.0/include -I/nix/store/aql117ic0q8syma8yl9y1gqnv244aqa5-openssl-1.0.2n-dev/include -I../deps/icu-small/source/common -I../deps/icu-small/source/i18n -I../deps/icu-small/source/tools/toolutil  -Os -gdwarf-2 -mmacosx-version-min=10.7 -arch x86_64 -Wall -Wendif-labels -W -Wno-unused-parameter -std=gnu++0x -stdlib=libc++ -fno-rtti -fno-exceptions -fno-threadsafe-statics -fno-strict-aliasing -MMD -MF /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/.deps//private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/obj.host/genccode/tools/icu/no-op.o.d.raw   -c -o /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/obj.host/genccode/tools/icu/no-op.o ../tools/icu/no-op.cc
  clang++ -Wl,-no_pie -Wl,-search_paths_first -mmacosx-version-min=10.7 -arch x86_64 -L/private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release -stdlib=libc++  -o "/private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/genccode" /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/obj.host/genccode/deps/icu-small/source/tools/genccode/genccode.o /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/obj.host/genccode/tools/icu/no-op.o /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/obj.host/tools/icu/libicutools.a -L/nix/store/dmj0jc03kkhq1238y88gm5rvppgvi2ff-zlib-1.2.11/lib -lz -L/nix/store/1ws18qwp1qr8fmjkawq54blddll4ngma-libuv-1.18.0/lib -luv -L/nix/store/f85paimpq2kybp51ldxkpljrkgrr1s7w-openssl-1.0.2n/lib -lcrypto -lssl
ld: file not found: /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[1]: *** [tools/icu/genccode.host.mk:183: /private/tmp/nix-build-nodejs-9.4.0.drv-0/node-v9.4.0/out/Release/genccode] Error 1
rm 1417c228ec7f22c7a2e76b1d2ab318643c67b2c6.intermediate
make: *** [Makefile:89: node] Error 2
builder for '/nix/store/v1ihbx4wffxx0s946xc50lmxmhxdcrb9-nodejs-9.4.0.drv' failed with exit code 2
error: build of '/nix/store/v1ihbx4wffxx0s946xc50lmxmhxdcrb9-nodejs-9.4.0.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

└───────────────────────────────────────────────────────────────┘
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0
shrinking /nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0/bin/node
gzipping man pages under /nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0/lib  /nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0/bin
patching script interpreter paths in /nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0
checking for references to /build in /nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0...
/nix/store/dfdybh1ypxlif9rjk671a2p1j79dja5d-nodejs-9.4.0

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

└───────────────────────────────────────────────────────────────┘
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0
shrinking /nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0/bin/node
gzipping man pages under /nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0/lib  /nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0/bin 
patching script interpreter paths in /nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0
checking for references to /tmp/nix-build-nodejs-9.4.0.drv-0 in /nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0...
/nix/store/9ppjg6cpz51mf84p8mzmrqdqim5h95pi-nodejs-9.4.0

@adisbladis adisbladis merged commit 9d56002 into NixOS:master Jan 11, 2018
@adisbladis
Copy link
Member

Thanks! :)

Darwin build is successful on my Darwin test machine.

@frontsideair frontsideair deleted the nodejs-9.4.0 branch January 11, 2018 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants