Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

magnetophonDSP: remove workarounds for: #34300

Merged
merged 1 commit into from Jan 27, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 26, 2018

https://bitbucket.org/agraef/faust-lv2/issues/10/tabs-break-lv2s
https://bitbucket.org/agraef/faust-lv2/issues/7/scale-log-breaks-plugins

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@magnetophon
Copy link
Member Author

magnetophon commented Jan 28, 2018

@adisbladis Thanks!

What are these rebuild labels for? I always assumed they indicate work to do for hydra, but these pkgs aren't built by hydra.

@magnetophon magnetophon deleted the magnetophonDSP branch January 28, 2018 00:39
@adisbladis
Copy link
Member

@magnetophon Yes they are to indicate how many package rebuilds a PR would result in on hydra, and since these are not built on hydra this PR has the 0 rebuilds label :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants