Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meme: init at 2017-09-10 #34299

Merged
merged 1 commit into from Jan 27, 2018
Merged

meme: init at 2017-09-10 #34299

merged 1 commit into from Jan 27, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 26, 2018

Motivation for this change

An example of a meme generated with this program

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@fgaz
Copy link
Member Author

fgaz commented Jan 26, 2018

I hope a name as short as this doesn't clash with something more important in the future

homepage = "https://github.com/nomad-software/meme";
license = licenses.mit;
maintainers = [ maintainers.fgaz ];
platforms = platforms.linux;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upstream says this should work on Mac. Have you tested to see if this builds on mac via Nixpkgs?

Copy link
Member Author

@fgaz fgaz Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have a mac to test it with. Should I set it to darwin too and try to trigger a build like you did?

edit: doing it

Copy link
Member Author

@fgaz fgaz Jan 26, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I... can't figure out how to do it. with platforms; [ linux darwin ] doesn't work. [ "x86_64-linux" "x86_64-darwin" "aarch64-linux" ] does, but strings are bad, right?

edit: found it. linux and darwin are lists of platforms, not platforms. So linux ++ darwin works.i miss static types

@grahamc
Copy link
Member

grahamc commented Jan 26, 2018

@GrahamcOfBorg build meme

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

patching script interpreter paths in /nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10
/nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/gen-data.sh: interpreter directive changed from "/bin/bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/github.com/golang/freetype/testdata/make-other-hinting-txts.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/sh"
/nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
/nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/rc78viijga8i0m4imrnqk8d1csyqr8yx-bash-4.4-p12/bin/bash"
checking for references to /build in /nix/store/444yvbmd70zk5rg4sr6ri2rc5k4hi1nm-meme-unstable-2017-09-10...
/nix/store/w15m3wj881ny05j098hs05mcx8w0p8w4-meme-unstable-2017-09-10-bin

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘meme-unstable-2017-09-10’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/graphics/meme/default.nix:18 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

patching script interpreter paths in /nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10
/nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/sh"
/nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/github.com/golang/freetype/testdata/make-other-hinting-txts.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
/nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/gen-data.sh: interpreter directive changed from "/bin/bash" to "/nix/store/i0ay05pqkbnvpfijm52mmlrp6kmkl80c-bash-4.4-p12/bin/bash"
checking for references to /tmp/nix-build-meme-unstable-2017-09-10.drv-0 in /nix/store/r3z6n6xfww6scvjcc6z9v9kxzcaxq1dl-meme-unstable-2017-09-10...
/nix/store/96zcnz5p6c56pazlqlf9biv5z5kkj9h7-meme-unstable-2017-09-10-bin

@fgaz
Copy link
Member Author

fgaz commented Jan 26, 2018

@GrahamcOfBorg build meme
edit: well, I tried

@fpletz
Copy link
Member

fpletz commented Jan 26, 2018

@GrahamcOfBorg build meme

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: aarch64-linux

/nix/store/w15m3wj881ny05j098hs05mcx8w0p8w4-meme-unstable-2017-09-10-bin

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

/nix/store/96zcnz5p6c56pazlqlf9biv5z5kkj9h7-meme-unstable-2017-09-10-bin

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-darwin

strip is /nix/store/i1zz228nl3bljcbb83fq0rq7lr7nvv4y-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10
/nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/gen-data.sh: interpreter directive changed from "/bin/bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/plan9/mksysnum_plan9.sh: interpreter directive changed from "/bin/sh" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/sh"
/nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/unix/mkall.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/golang.org/x/sys/unix/mkerrors.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/2klzvinswc8gmdnyccj2dxp1nk85yfmg-meme-unstable-2017-09-10/share/go/src/github.com/nomad-software/meme/vendor/github.com/golang/freetype/testdata/make-other-hinting-txts.sh: interpreter directive changed from "/usr/bin/env bash" to "/nix/store/4cvvpbqdkrb0hr4p47q3s9l2a6k04y1g-bash-4.4-p12/bin/bash"
/nix/store/mba60l24w8viw8frzk4kldd4bgpqnz78-meme-unstable-2017-09-10-bin

@grahamc grahamc merged commit b5dbc83 into NixOS:master Jan 27, 2018
@fgaz fgaz deleted the meme branch January 27, 2018 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants