Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

distrho: 2017-10-10 -> 2018-01-01 #34298

Merged
merged 1 commit into from Jan 27, 2018
Merged

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 26, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@@ -2,12 +2,12 @@
, libxslt, lv2, pkgconfig, premake3, xorg, ladspa-sdk }:

stdenv.mkDerivation rec {
name = "distrho-ports-unstable-2017-10-10";
name = "distrho-ports-unstable-2018-01-01";

src = fetchgit {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR itself is fine but I would appreciate it if we could change this to use fetchFromGitHub.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, done.

@grahamc
Copy link
Member

grahamc commented Jan 26, 2018

@GrahamcOfBorg build distrho

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘distrho-ports-unstable-2018-01-01’ in /tmp/nix-ofborg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/lnl7-mac/pkgs/applications/audio/distrho/default.nix:38 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

g++: error: unrecognized command line option '-msse'; did you mean '-fdse'?
g++: error: unrecognized command line option '-msse2'
make[3]: *** [drowaudio.make:87: intermediate/Release/dRowAudio.o] Error 1
make[2]: *** [Makefile:22: drowaudio] Error 2
make[2]: Leaving directory '/build/source/libs/drowaudio/build-drowaudio'
make[1]: *** [Makefile:4: all] Error 2
make[1]: Leaving directory '/build/source/libs/drowaudio'
make: *** [Makefile:98: lv2] Error 2
builder for '/nix/store/3v624krxb818bayr3vj7w1rma8sybf5r-distrho-ports-unstable-2018-01-01.drv' failed with exit code 2
error: build of '/nix/store/3v624krxb818bayr3vj7w1rma8sybf5r-distrho-ports-unstable-2018-01-01.drv' failed

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/lib/lv2/drowaudio-distortionshaper.lv2/drowaudio-distortionshaper.so
shrinking /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/lib/lv2/drowaudio-flanger.lv2/drowaudio-flanger.so
shrinking /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/lib/lv2/drowaudio-reverb.lv2/drowaudio-reverb.so
shrinking /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/lib/lv2/drowaudio-tremolo.lv2/drowaudio-tremolo.so
shrinking /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/lib/lv2/drumsynth.lv2/drumsynth.so
shrinking /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/lib/lv2/eqinox.lv2/eqinox.so
strip is /nix/store/mdyy001q67hiks0g24ra53z7ckm4jfr4-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/lib  /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01/bin 
patching script interpreter paths in /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01
checking for references to /tmp/nix-build-distrho-ports-unstable-2018-01-01.drv-0 in /nix/store/p39bn7fw6872gfya5s4y763h4n9ldjch-distrho-ports-unstable-2018-01-01...

@magnetophon
Copy link
Member Author

Why is borg building for darwin when the pkg says platforms = platforms.linux;?

@grahamc
Copy link
Member

grahamc commented Jan 27, 2018

It is too dumb to know otherwise :)

@adisbladis
Copy link
Member

adisbladis commented Jan 27, 2018

I attempted a fix for the aarch64 build error in #34316

Lets merge this update and address aarch64 separately :)

@adisbladis adisbladis merged commit 7d835c2 into NixOS:master Jan 27, 2018
@magnetophon magnetophon deleted the distrho branch January 27, 2018 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants