pythonPackages.nimfa: init at 1.3.1 #33918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRidh
requested changes
Jan 16, 2018
| }: | ||
|
|
||
| buildPythonPackage rec { | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
Python packages shouldn't have a name?
There was a problem hiding this comment.
buildPythonPackage will automatically set the name according to pname and version.
| }; | ||
|
|
||
| propagatedBuildInputs = [ numpy scipy ]; | ||
| buildInputs = [ matplotlib pytest ]; |
|
|
||
| propagatedBuildInputs = [ numpy scipy ]; | ||
| buildInputs = [ matplotlib pytest ]; | ||
| doCheck = false; # errors |
There was a problem hiding this comment.
What kind of errors? Are these upstream issues? If so, did you report them?
|
I believe all changes have been made |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New Python package for nonnegative matrix factorization (maths and science).
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)