hll2390dw-cups: init at 4.0.0-1 #33919
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbogdan
reviewed
Jan 16, 2018
| @@ -19765,6 +19765,8 @@ with pkgs; | |||
|
|
|||
| canon-cups-ufr2 = callPackage ../misc/cups/drivers/canon { }; | |||
|
|
|||
| hll2390dw-cups = callPackage ../misc/cups/drivers/hll2390dw-cups { }; | |||
There was a problem hiding this comment.
Directory name mismatch? - the default.nix added here seems to live in pkgs/misc/drivers/hll2390dw/default.nix
There was a problem hiding this comment.
Well, that's embarassing, I was under the impression that nix-build would've failed, but it seems it either used the system's overlay or the system's packages when building? Unsetting NIX_PATH before nix-building showed very well that it never worked in that repo, it worked very well in my overlay though. It is now fixed.
|
Updates:
|
samueldr
force-pushed
the
feature/hll2390dw-cups
branch
from
80a8b06
to
22de8e1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Adding the driver for my printer.
This driver is unified, it has both the lpr and cupswrapper parts in one, when compared to other older brother drivers. This is why I used the
-cupssuffix. I definitely didn't know what to use.Things done
build-use-sandboxinnix.confon non-NixOS)