pythonPackages.progressbar2: init at 3.12.0 #33920
Conversation
ashgillman
force-pushed
the
add-progressbar2
branch
from
975c192
to
99e035a
Compare
There was a problem hiding this comment.
Why did you disable tests?
setup.py seems to download missing requirements:
Download error on https://pypi.python.org/simple/pytest-runner/: [Errno -2] Name or service not known -- Some packages may not be found!
Download error on https://pypi.python.org/simple/: [Errno -2] Name or service not known -- Some packages may not be found!
But no luck even if we use pytestrunner from nixpkgs, since pytest-runner>=2.8 is required. We will need to update it beforhand.
Maybe you didn't see the download errors if you don't have enabled sandboxing.
| }: | ||
|
|
||
| buildPythonPackage (rec { | ||
| name = "${pname}-${version}"; |
There was a problem hiding this comment.
No need for name. Will be derived from pname and version.
Also, you can leave out ( and ).
| sha256 = "16r21cpjvv0spf4mymgpy7hx6977iy11k44n2w9kipwg4lhwh02k"; | ||
| }; | ||
|
|
||
| buildInputs = [ pytest ]; |
There was a problem hiding this comment.
pytest belongs into checkInputs.
|
Last commit should have dealt with all issues. I had a little trouble getting tests to run, and currently need to pull from GitHub, not PyPI (notified upstream, commented in expression). |
|
@FRidh Shouldn't have been merged. I still get We need to add |
|
Right, I missed that. It seems |
Motivation for this change
New python package, simple to use progress bar
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)