Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wakatime: don't run check phase #33917

Merged
merged 2 commits into from Jan 16, 2018
Merged

wakatime: don't run check phase #33917

merged 2 commits into from Jan 16, 2018

Conversation

ashgillman
Copy link
Contributor

Motivation for this change

Wakatime would not previously build for me (nix-build -A wakatime).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Mic92
Copy link
Member

Mic92 commented Jan 16, 2018

Can you test this update? I added the root cause, why tests do not work yet too.

@ashgillman
Copy link
Contributor Author

Yes, this works. Thanks :)

@Mic92 Mic92 merged commit 1c9d599 into NixOS:master Jan 16, 2018
@jtojnar jtojnar mentioned this pull request Jan 16, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ashgillman @Mic92 @GrahamcOfBorg