Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kpcli: Fix darwin build #33913

Merged
merged 3 commits into from Jan 16, 2018
Merged

kpcli: Fix darwin build #33913

merged 3 commits into from Jan 16, 2018

Conversation

ciderale
Copy link
Contributor

Motivation for this change

Fix kpcli build on darwin as part of #29221

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@ciderale
perlPackages.MacPasteboard: init at 0.009
9ea67c1
@ciderale
perlPackages.Clipboard: Fix darwin build
9e2e219 
Darwin requires dependency on MacPasteboard

The test runs successfully when executed interactively from a nix-shell.
Disable doCheck as paste pasteboard is not accessible in (non-interactive) nix-build.
@ciderale
kpcli: Fix darwin build
f198189 
adding MacPasteboard to perl path to support using clipboard on darwin
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jan 16, 2018
@LnL7 LnL7 merged commit 75936c4 into NixOS:master Jan 16, 2018
@LnL7
Copy link
Member

LnL7 commented Jan 16, 2018

Thanks!

@LnL7 LnL7 added the 8.has: port to stable A PR already has a backport to the stable release. label Jan 16, 2018
@LnL7
Copy link
Member

LnL7 commented Jan 16, 2018

Backported in 855fbf5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 LnL7 approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ciderale @LnL7 @GrahamcOfBorg @Janik-Haag