Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mighttpd2: add service #33911

Merged
merged 1 commit into from Jan 16, 2018
Merged

mighttpd2: add service #33911

merged 1 commit into from Jan 16, 2018

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 15, 2018

Motivation for this change

A service option for the mighttpd2 web server

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

srhb
srhb reviewed Jan 16, 2018
View reviewed changes
nixos/modules/services/web-servers/mighttpd2.nix

users.extraUsers.mighttpd2 = {
group = "mighttpd2";
uid = config.ids.uids.mighttpd2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neither the uid nor the gid appear to be defined in nixos/modules/misc/ids.nix

I think you should add these. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done & done (& rebased).

Sorry, I forgot to git add those two files

@srhb
Copy link
Contributor

srhb commented Jan 16, 2018

You probably also want to add the module to nixos/modules/module-list.nix so that it becomes available without an explicit module import. :)

@srhb
Copy link
Contributor

srhb commented Jan 16, 2018

I don't know if you're aware, but it's possible to specify a maintainers list for NixOS modules as well. Would you care to add yourself?

Could you also redo the commit message to conform with CONTRIBUTING.md? That is: nixos/mighttpd2: init

I think that should suffice for inclusion. :)

@fgaz
Copy link
Member Author

fgaz commented Jan 16, 2018 •
edited

Oh, I thought both of those things were for packages only.

Done (I already am in the maintainers module)

edit: wait, I managed to type the wrong thing in the commit message done

@srhb srhb merged commit 49616bd into NixOS:master Jan 16, 2018
@srhb
Copy link
Contributor

srhb commented Jan 16, 2018

Thanks!

@fgaz fgaz deleted the mighttpd2 branch January 16, 2018 21:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srhb srhb srhb left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fgaz @srhb @GrahamcOfBorg