Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for generic counter_raw_values performance counter type #3103

Merged
merged 1 commit into from Jan 22, 2018
Merged

Adding support for generic counter_raw_values performance counter type #3103

merged 1 commit into from Jan 22, 2018

Conversation

hkaiser
Copy link
Member

@hkaiser hkaiser commented Jan 15, 2018

Proposed Changes

  • adding support for new generic performance counter type that returns an array of values

Any background context you want to provide?

@hkaiser hkaiser added this to the 1.1.0 milestone Jan 15, 2018
@hkaiser hkaiser mentioned this pull request Jan 19, 2018
Closed
parsa
parsa approved these changes Jan 22, 2018
View reviewed changes
Copy link
Contributor

@parsa parsa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This performance counter does return an array of arbitrary sizes and works as intended. Thanks!

$ ./counter_raw_values_test.exe --hpx:print-counter=/test{locality#*/total}/values
/test{locality#0/total}/values,11,1.739444,[s],10:11:12:13:14:15:16:17:18:19

@hkaiser hkaiser merged commit 29da281 into master Jan 22, 2018
@hkaiser hkaiser deleted the fixing_3102 branch January 22, 2018 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@parsa parsa parsa approved these changes

Assignees
No one assigned
Labels
category: performance counters type: enhancement
Projects
None yet
Milestone
1.1.0
Development

Successfully merging this pull request may close these issues.

Introduce generic performance counter type returning an array of values
2 participants
@hkaiser @parsa