Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: glibc: fix CVE-2018-1000001 (getcwd() absolute path issue) #33909

Closed
wants to merge 1 commit into from
Closed

WIP: glibc: fix CVE-2018-1000001 (getcwd() absolute path issue) #33909

wants to merge 1 commit into from

Conversation

andir
Copy link
Member

@andir andir commented Jan 15, 2018

Motivation for this change

Fixing CVE-2018-1000001.

I am currently trying to verify if stuff obviously breaks. My build machine just started building...

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@andir
Copy link
Member Author

andir commented Jan 15, 2018

Would be great if @vcunat could have a look. You did most of the glibc patching so far :-)

@pbogdan
Copy link
Member

pbogdan commented Jan 15, 2018 •
edited

Seems like a fix is already in staging? - 990ff97c6d8

@andir
Copy link
Member Author

andir commented Jan 15, 2018

Alright didn't check there since yesterday. Thanks!

@andir andir closed this Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 501+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@andir @pbogdan @GrahamcOfBorg