flex: fix for cross #34170
Merged
flex: fix for cross #34170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
requested changes
Jan 23, 2018
| buildInputs = [ bison ]; | ||
|
|
||
| propagatedBuildInputs = [ m4 ]; | ||
| nativePropagatedBuildInputs = [ m4 ]; |
There was a problem hiding this comment.
nativePropagatedBuildInputs isn't a thing (it would be propagatedNativeBuildInputs) but I don't think this needs to be changed at all.
|
|
||
| nativeBuildInputs = [ buildPackages.stdenv.cc autoreconfHook help2man ]; |
There was a problem hiding this comment.
buildPackages.stdenv.cc should be a depsBuildBuild.
| buildInputs = [ bison ]; | ||
|
|
||
| propagatedBuildInputs = [ m4 ]; | ||
| nativePropagatedBuildInputs = [ m4 ]; | ||
|
|
||
| postConfigure = stdenv.lib.optionalString (stdenv.isDarwin || stdenv.isCygwin) '' | ||
| sed -i Makefile -e 's/-no-undefined//;' | ||
| ''; | ||
|
|
||
| crossAttrs = { |
There was a problem hiding this comment.
I wan't to get rid of crossAttrs, so could you make all the inner attributes conditional "top-level" ones instead?
* top-level attributes, not crossAttrs * use depsBuildBuild
Ericson2314
added
the
6.topic: cross-compilation
|
Feedback addressed, but need to rebuild-all-the-things to test it still builds properly. |
Ericson2314
approved these changes
Jan 23, 2018
|
I unchecked the box for you |
|
Tested on aarch64. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)