Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: jruby/jruby
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 49b9caa8e2ae
Choose a base ref
...
head repository: jruby/jruby
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: ffb23fcb0046
Choose a head ref
  • 17 commits
  • 14 files changed
  • 3 contributors

Commits on Jan 19, 2018

  1. introduce a 'fast' isZero for Numerics + also override pos/neg checks 

    + cleanup RubyRational's internals - confusing IRubyObject clazz param
    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    641aac0 View commit details

  2. cleanup code in RubyFloat#rationalize - gen. slightly less noise

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    2e9095a View commit details

  3. unify double -> BigInteger conversion + override convertToInt on Float

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    c903f31 View commit details

  4. negate Fixnum properly (like uminus) + normalize negated Bignum

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    20fa61f View commit details

  5. overload/reimpl Numeric ops with Integers + re-invent a 'fast' gcd

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    b78d7de View commit details

  6. dont 'abuse' newEmptyString in Rational's to_s/inspect implementation

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    0aeb492 View commit details

  7. add (private for now) isNegative/Positive helpers for Integer types

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    ac815f8 View commit details

  8. revisit Rational impl - invent 'fast' Integer over-loads where possible

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    15327dd View commit details

  9. refactor nurat_rationalize to save an ary + introduce more op overloads

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    36ff6cf View commit details

  10. [test] Rational/Float (integer conversion + signum) on the Java end

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    dd958e8 View commit details

  11. review String#to_r impl + refactor and cleanup str_to_r_internal

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    5d61b99 View commit details

  12. [refactor] compare long values instead of assuming fixnum object ==

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    61a117a View commit details

  13. [refactor] use Integer (overload) operations in RubyFloat#to_r

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    d51c7d2 View commit details

  14. check for Integer when converting 2 Rational + simplify internals more

    @kares
    kares committed Jan 19, 2018
    Copy the full SHA
    cce752c View commit details

Commits on Jan 22, 2018

  1. Avoid race when deduplicating frozen strings. Fixes #4970. 

    The logic here goes like this:

* Attempt to lookup the dedup'ed string.
* If found, return it.
* Try to insert new dedup'ed string.
* If nobody beat us to it, return it.
* If someone beat us to it and the reference is still good, return
  it.
* If someone beat us to it and the reference is vacated,
  atomically replace it or retrieve any updates that beat us.
* Keep trying until we succeed in updating or get back a populated
  reference.

Previously, there could be a race if two threads try to dedup the
same string at the same time. Only one would get in the cache, but
the n+1 threads might not return the already-cached value.
    @headius
    headius committed Jan 22, 2018
    Copy the full SHA
    239ef50 View commit details

  2. Merge branch 'master' into bytelist_love

    @enebo
    enebo committed Jan 22, 2018
    Copy the full SHA
    914742c View commit details

  3. Symbols strings should be raw

    @enebo
    enebo committed Jan 22, 2018
    Copy the full SHA
    ffb23fc View commit details
Loading