Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc841: update to 8.4.1-alpha2 #34172

Merged
merged 1 commit into from Jan 23, 2018
Merged

ghc841: update to 8.4.1-alpha2 #34172

merged 1 commit into from Jan 23, 2018

Conversation

deepfire
Copy link
Contributor

@deepfire deepfire commented Jan 22, 2018 •
edited

Motivation for this change

Update ghc841 to -alpha2.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@deepfire deepfire requested a review from peti as a code owner January 22, 2018 23:00
@deepfire
Copy link
Contributor Author

deepfire commented Jan 22, 2018 •
edited

Tuning heuristics of the configuration-ghc-*.nix override set trimmer, meanwhile..

I have (semi-) naively started with just iterating for all overridden derivations and for each overridden property of those -- turning them off individually, rebuilding and tracking the results. That got pretty far, however..

One (somewhat predictable) problem is changing properties of one derivation (naturally) leading to changes in another one -- and so the search space suddenly becomes very large, and expensive to traverse, because:

  • you no longer can independently tweak properties of derivations, and pretend things will keep working
  • by extension, proper validation implies rebuild of a preferably total package set

So, we're going to have to settle on some kind of compromise strategy, naturally relying on manual guidance and, I guess, sub-optimal trimming of the override set.

@peti peti merged commit 4bed2d6 into NixOS:master Jan 23, 2018
@peti
Copy link
Member

peti commented Jan 26, 2018

This update does not compile: https://nix-cache.s3.amazonaws.com/log/zhxjgmilqh5bnp16rv0fx4b6bcrhxf2a-ghc-61db0b8.drv.

peti added a commit to peti/nixpkgs that referenced this pull request Jan 26, 2018
@peti
ghc-8.4.1: revert "update to 8.4.1-alpha2"
a74b0e7 
This reverts commit d232856 from
NixOS#34172. The new version does not compile:
https://nix-cache.s3.amazonaws.com/log/zhxjgmilqh5bnp16rv0fx4b6bcrhxf2a-ghc-61db0b8.drv.
@deepfire
Copy link
Contributor Author

deepfire commented Jan 26, 2018 •
edited

@peti, I believe it's #34229, fixed in #34232

@peti
Copy link
Member

peti commented Jan 26, 2018

OK. I've applied the update again in 83f88b347685c40e3ea1af6b5f0388cd557ab03b, which is re-based to the current master. Let's hope this succeeds now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@deepfire @peti @GrahamcOfBorg