Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clang-{4,5}: prefer python3, much friendlier for cross #34178

Merged
merged 1 commit into from Jan 23, 2018
Merged

clang-{4,5}: prefer python3, much friendlier for cross #34178

merged 1 commit into from Jan 23, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 22, 2018

python3 is significantly more cross-friendly,
prefer it when building clang to make satisfying
the dependency less burdensome when cross-compiling.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jan 23, 2018
@Ericson2314 Ericson2314 merged commit 2427030 into NixOS:staging Jan 23, 2018
@dtzWill dtzWill deleted the fix/clang-python3 branch January 23, 2018 01:25
@Ericson2314 Ericson2314 added this to After big PR in Cross compilation Jan 23, 2018
@dtzWill
Copy link
Member Author

dtzWill commented Jan 23, 2018

Hmm, I didn't consider potential impact on Darwin... cc @LnL7 @copumpkin will this be a problem?

(if it's a big problem, we can revert until other llvm/clang cross-compilation pieces are ready)

@copumpkin
Copy link
Member

copumpkin commented Jan 23, 2018 •
edited

Yes, big problem. Or at the very least, needs to be tested very carefully. We have a delicate bootstrapping dance on darwin that by necessity includes python only for the sake of clang (because otherwise I'd sure as hell kill it), and it currently includes python2. So unless you've gone and carefully updated that, this will kill the platform.

@copumpkin copumpkin mentioned this pull request Jan 23, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on
Projects
No open projects
Cross compilation
After big PR
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @copumpkin @Ericson2314