python-cffi: fix clang build #34158
Merged
python-cffi: fix clang build #34158
+1
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Builds fine without it now.
|
@GrahamcOfBorg build python3Packages.cffi python2Packages.cffi |
There was a problem hiding this comment.
Success for system: x86_64-darwin
% (self.verifier.get_module_name()))
testing/cffi0/test_verify2.py::test_win32_calling_convention_3
/private/tmp/nix-build-python3.6-cffi-1.11.4.drv-0/cffi-1.11.4/cffi/vengine_cpy.py:192: UserWarning: reimporting '_cffi__xc5b5e469x752fb969' might overwrite older definitions
% (self.verifier.get_module_name()))
-- Docs: http://doc.pytest.org/en/latest/warnings.html
===== 1822 passed, 143 skipped, 4 xfailed, 194 warnings in 331.91 seconds ======
/nix/store/nnwyqpka2s54y7w5mma8c383ghfxgfpx-python3.6-cffi-1.11.4
/nix/store/ich6qlkwc000xsg1ss1i05c8f0fdl9ly-python2.7-cffi-1.11.4
Mic92
approved these changes
Jan 22, 2018
|
I guess we should queue this for staging instead? |
|
Dunno, master is already broken anyway. |
There was a problem hiding this comment.
Success for system: x86_64-linux
% (self.verifier.get_module_name()))
testing/cffi0/test_verify2.py::test_ffi_gc_size_arg
/tmp/nix-build-python3.6-cffi-1.11.4.drv-0/cffi-1.11.4/cffi/vengine_cpy.py:192: UserWarning: reimporting '_cffi__xa155022ax7f1150e2' might overwrite older definitions
% (self.verifier.get_module_name()))
-- Docs: http://doc.pytest.org/en/latest/warnings.html
====== 1876 passed, 89 skipped, 4 xfailed, 202 warnings in 200.96 seconds ======
/nix/store/q4hx38x4fkbgj3ick114mflicyh25q48-python3.6-cffi-1.11.4
/nix/store/ibgvw4nhlvc0kpd88b789qbynhnjym5z-python2.7-cffi-1.11.4
I'll merge master into staging so we don't have unnecessary rebuilds. |
There was a problem hiding this comment.
Success for system: aarch64-linux
/nix/store/7wdhdh91j6fn9323rx45sbc4f01wk1sm-expat-2.2.5
/nix/store/mhlap6kz8zcr3bhw52v8j8zgwl5srzpw-python3.6-cffi-1.11.4
/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4
/nix/store/r5c2fd1mn4wksbyzxqgda8whdqk3k6z5-python2.7-cffi-1.11.4
copying path '/nix/store/r5c2fd1mn4wksbyzxqgda8whdqk3k6z5-python2.7-cffi-1.11.4' from 'https://cache.nixos.org'...
copying path '/nix/store/7wdhdh91j6fn9323rx45sbc4f01wk1sm-expat-2.2.5' from 'https://cache.nixos.org'...
copying path '/nix/store/mn2c28fa7mp8ck3p74n80nls6g2w7flw-python3-3.6.4' from 'https://cache.nixos.org'...
copying path '/nix/store/mhlap6kz8zcr3bhw52v8j8zgwl5srzpw-python3.6-cffi-1.11.4' from 'https://cache.nixos.org'...
/nix/store/mhlap6kz8zcr3bhw52v8j8zgwl5srzpw-python3.6-cffi-1.11.4
/nix/store/r5c2fd1mn4wksbyzxqgda8whdqk3k6z5-python2.7-cffi-1.11.4
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
A lot of packages depend on this and broke.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)