Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice: add Spanish (es) language support and sort langs list #34159

Merged
merged 1 commit into from Jan 22, 2018
Merged

libreoffice: add Spanish (es) language support and sort langs list #34159

merged 1 commit into from Jan 22, 2018

Conversation

arcadio
Copy link
Contributor

@arcadio arcadio commented Jan 22, 2018

Motivation for this change

Add support for Spanish language.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

Can't test right now as current derivation for libreoffice seems broken with some unit tests failing:

https://hydra.nixos.org/build/67781593


@viric

@arcadio arcadio changed the title libreoffice: Add Spanish (es) language support and sort langs list libreoffice: add Spanish (es) language support and sort langs list Jan 22, 2018
@7c6f434c
Copy link
Member

Probably it is more like @ me…

Segfault in tests is probably caused by some update outside the LibreOffice package, I guess…

@7c6f434c 7c6f434c merged commit dda1a7f into NixOS:master Jan 22, 2018
@arcadio arcadio deleted the libreoffice-es branch May 14, 2018 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants