Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: fix for cross, add missing configure test override #34157

Merged
merged 1 commit into from Jan 22, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 22, 2018

vim currently doesn't build on cross (for armv6l or aarch64 anyway),
complaining about unable to test what tgetent does in special circumstances.

Since this is a mentioned issue in the vim installation documentation,
this commit adds it to the set of variables we set/override when
cross-compiling.

This fixes cross-compilation of vim on the platforms mentioned above!

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

This is one of the variables mentioned to set
when cross-compiling:

https://github.com/vim/vim/blob/master/src/INSTALLx.txt

@Mic92 Mic92 merged commit 0c1805b into NixOS:master Jan 22, 2018
@Ericson2314 Ericson2314 added the 6.topic: cross-compilation Building packages on a different sort platform than than they will be run on label Jan 22, 2018
@Ericson2314
Copy link
Member

Thanks!

@dtzWill dtzWill deleted the fix/vim-cross branch January 23, 2018 01:26
@Ericson2314 Ericson2314 added this to After big PR in Cross compilation Jan 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different sort platform than than they will be run on 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
No open projects
Cross compilation
After big PR
Development

Successfully merging this pull request may close these issues.

None yet

4 participants