Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sharutils: don't hardcode AR #33482

Merged
merged 1 commit into from Jan 6, 2018
Merged

sharutils: don't hardcode AR #33482

merged 1 commit into from Jan 6, 2018

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 5, 2018

Motivation for this change

Fixes cross-build by avoiding invoking naked 'ar'.

Huge rebuild, unfortunately.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@orivej
Copy link
Contributor

orivej commented Jan 6, 2018

How is $AR different from ar during cross compilation?

@dtzWill
Copy link
Member Author

dtzWill commented Jan 6, 2018

It's the prefixed 'ar', for example when using the raspberryPi cross 'example', it's: armv6l-unknown-linux-gnueabihf-ar.

Same as using $CC these days instead of cc.

Functionality-wise I'm not honestly sure what ar does differently for different platforms, at least in practice. The problem being fixed here is that naked ar doesn't exist on PATH when cross-compiling (and if it did, it'd be the 'wrong' one).

@orivej orivej changed the base branch from master to staging January 6, 2018 17:01
@orivej
Copy link
Contributor

orivej commented Jan 6, 2018

OK. Please explain this in the commit message too, otherwise it's too mysterious without the reference to your comment.

@dtzWill
sharutils: don't hardcode AR to 'ar' (doesn't exist on cross)
2b230ef 
Instead, let the default value of $AR indicate what should be used.

(which will be something like `armv6l-unknown-linux-gnueabihf-ar`)
@dtzWill
Copy link
Member Author

dtzWill commented Jan 6, 2018

@orivej sure thing, pushed new commit with some explanation!

@orivej orivej merged commit 6277246 into NixOS:staging Jan 6, 2018
@orivej
Copy link
Contributor

orivej commented Jan 6, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @orivej @GrahamcOfBorg