apache-httpd: enable brotli support by default #33481
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build apacheHttpd |
zimbatm
reviewed
Jan 6, 2018
| @@ -4,13 +4,15 @@ | |||
| , http2Support ? true, nghttp2 | |||
| , ldapSupport ? true, openldap | |||
| , libxml2Support ? true, libxml2 | |||
| , brotliSupport ? true, brotli ? null | |||
There was a problem hiding this comment.
what is the purpose of the null default?
There was a problem hiding this comment.
@zimbatm I copied this pattern from the curl default.nix: https://github.com/NixOS/nixpkgs/blob/master/pkgs/tools/networking/curl/default.nix#L11
I figured being explicit about arguments was a good idea. I'm still learning nix so am open to better patterns, idiom etc.
There was a problem hiding this comment.
I see. Since nix is lazily-evaluated it's not a problem to always pass brotli. curl is a bit special as it is used during the stdenv bootstrap where these libraries aren't available at all.
There was a problem hiding this comment.
ah, thanks for the explanation. I'll PR to keep the style consistent.
There was a problem hiding this comment.
Success for system: x86_64-linux
shrinking RPATHs of ELF executables and libraries in /nix/store/6754msz9wzarc36z7j99ni0m7kkly311-apache-httpd-2.4.29-man
gzipping man pages under /nix/store/6754msz9wzarc36z7j99ni0m7kkly311-apache-httpd-2.4.29-man/share/man/
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/6754msz9wzarc36z7j99ni0m7kkly311-apache-httpd-2.4.29-man
checking for references to /tmp/nix-build-apache-httpd-2.4.29.drv-0 in /nix/store/6754msz9wzarc36z7j99ni0m7kkly311-apache-httpd-2.4.29-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/h6zwai5p4mdmwwc2ksszka7j2yvygcny-apache-httpd-2.4.29-doc
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/h6zwai5p4mdmwwc2ksszka7j2yvygcny-apache-httpd-2.4.29-doc
checking for references to /tmp/nix-build-apache-httpd-2.4.29.drv-0 in /nix/store/h6zwai5p4mdmwwc2ksszka7j2yvygcny-apache-httpd-2.4.29-doc...
/nix/store/glqdndz4x8h005qfjwf1cy60g9r7cvqk-apache-httpd-2.4.29
There was a problem hiding this comment.
Success for system: x86_64-darwin
patching script interpreter paths in /nix/store/bhqdhkxcp8xaqsr0k6y3z4idvml65ccw-apache-httpd-2.4.29-dev
/nix/store/bhqdhkxcp8xaqsr0k6y3z4idvml65ccw-apache-httpd-2.4.29-dev/share/build/mkdir.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/sh"
/nix/store/bhqdhkxcp8xaqsr0k6y3z4idvml65ccw-apache-httpd-2.4.29-dev/share/build/instdso.sh: interpreter directive changed from "/bin/sh" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/sh"
/nix/store/bhqdhkxcp8xaqsr0k6y3z4idvml65ccw-apache-httpd-2.4.29-dev/share/build/config.nice: interpreter directive changed from " /bin/sh" to "/nix/store/hgsbnqhg7zr5vbjazb250ac4wnj3cfhy-bash-4.4-p12/bin/sh"
gzipping man pages under /nix/store/4nnmfx9dn23dd9crg1hnd40bvr93d07w-apache-httpd-2.4.29-man/share/man/
strip is /nix/store/bhfkh37smh9lc5bngdha6zx98k6w6cgd-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/4nnmfx9dn23dd9crg1hnd40bvr93d07w-apache-httpd-2.4.29-man
strip is /nix/store/bhfkh37smh9lc5bngdha6zx98k6w6cgd-cctools-binutils-darwin/bin/strip
patching script interpreter paths in /nix/store/1i2y31a5fdlfjas2hd48id5vi8rfd9bi-apache-httpd-2.4.29-doc
/nix/store/p2k95k6cf3mclwgs5vx4apdzzdn73wcr-apache-httpd-2.4.29
There was a problem hiding this comment.
Success for system: aarch64-linux
shrinking RPATHs of ELF executables and libraries in /nix/store/88m6lvyrxqwmbjf5x3icgk2fzn0jm1m2-apache-httpd-2.4.29-man
gzipping man pages under /nix/store/88m6lvyrxqwmbjf5x3icgk2fzn0jm1m2-apache-httpd-2.4.29-man/share/man/
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/88m6lvyrxqwmbjf5x3icgk2fzn0jm1m2-apache-httpd-2.4.29-man
checking for references to /build in /nix/store/88m6lvyrxqwmbjf5x3icgk2fzn0jm1m2-apache-httpd-2.4.29-man...
shrinking RPATHs of ELF executables and libraries in /nix/store/7g54dv4rwwh87va92zgr03q6v59p5mdm-apache-httpd-2.4.29-doc
strip is /nix/store/c6qj0j45xizkrx58i65j75a5ysmqhgrs-binutils-2.28.1/bin/strip
patching script interpreter paths in /nix/store/7g54dv4rwwh87va92zgr03q6v59p5mdm-apache-httpd-2.4.29-doc
checking for references to /build in /nix/store/7g54dv4rwwh87va92zgr03q6v59p5mdm-apache-httpd-2.4.29-doc...
/nix/store/syf96c6y5gqa618i3l12g1527i5laiy4-apache-httpd-2.4.29
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Enable mod_brotli by default. Brotli is modern compression format.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)