qca2 and qca-qt5: use system CA certificates #33466
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CMakeLists.txt looks for the system CA bundle in several locations, including /etc/ssl/certs/ca-certificates.crt. This works for non-sandboxed builds but fails inside a sandbox.
|
@ttuegel @svanderburg any feedback? :) |
ttuegel
reviewed
Jan 20, 2018
| @@ -14,6 +14,12 @@ stdenv.mkDerivation rec { | |||
|
|
|||
| enableParallelBuilding = true; | |||
|
|
|||
| # tells CMake to use this CA bundle file if it is accessible | |||
| preConfigure = ''export QC_CERTSTORE_PATH=/etc/ssl/certs/ca-certificates.crt''; | |||
There was a problem hiding this comment.
The path to /etc/ssl/certs/ca-certificates.crt is compiled into the library and is used at runtime.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Sandboxed builds fail to detect the presence of
/etc/ssl/certs/ca-certificates.crt. As a result, qca does not use the system CA bundle and considers all certificates as untrusted. This PR fixes that.Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)