Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setbfree: 0.8.0 -> 0.8.5 #33490

Merged
merged 1 commit into from Jan 6, 2018
Merged

setbfree: 0.8.0 -> 0.8.5 #33490

merged 1 commit into from Jan 6, 2018

Conversation

magnetophon
Copy link
Member

@magnetophon magnetophon commented Jan 5, 2018

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@grahamc
Copy link
Member

grahamc commented Jan 5, 2018

@GrahamcOfBorg build setbfree

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: x86_64-darwin

Package ‘setbfree-0.8.5’ in /Users/graham/nix-borg/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-zoidberg/pkgs/applications/audio/setbfree/default.nix:27 is not supported on ‘x86_64-darwin’, refusing to evaluate.

a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowBroken = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowBroken = true; }
to ~/.config/nixpkgs/config.nix.

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Success for system: x86_64-linux

shrinking /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5/bin/setBfree
shrinking /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5/lib/lv2/b_synth/b_synth.so
shrinking /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5/lib/lv2/b_whirl/b_whirl.so
shrinking /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5/lib/lv2/b_overdrive/b_overdrive.so
shrinking /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5/lib/lv2/b_reverb/b_reverb.so
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5/lib  /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5/bin 
patching script interpreter paths in /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5
checking for references to /tmp/nix-build-setbfree-0.8.5.drv-0 in /nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5...
/nix/store/dy57rd7ff39vg0l04zb0017n73ch8aqr-setbfree-0.8.5

Copy link

@GrahamcOfBorg GrahamcOfBorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failure for system: aarch64-linux

LV2 Version: 2058 0
gcc  -msse -msse2 -mfpmath=sse -ffast-math -fomit-frame-pointer -O3 -fno-finite-math-only -Wall -fPIC -DVERSION="\"0.8.5\"" -DHAVE_LV2_1_8 -DHAVE_MEMSTREAM -c -o overdrive.o overdrive.c
gcc: error: unrecognized command line option '-msse'; did you mean '-fdse'?
gcc: error: unrecognized command line option '-msse2'
gcc: error: unrecognized command line option '-mfpmath=sse'
make[1]: *** [Makefile:51: overdrive.o] Error 1
make[1]: Leaving directory '/build/setBfree-0.8.5/b_overdrive'
make: *** [Makefile:26: b_overdrive] Error 2
builder for '/nix/store/x1r4giszjnr1naw9xy9caghsw871aabh-setbfree-0.8.5.drv' failed with exit code 2
error: build of '/nix/store/x1r4giszjnr1naw9xy9caghsw871aabh-setbfree-0.8.5.drv' failed

@grahamc
Copy link
Member

grahamc commented Jan 5, 2018

@magnetophon is this expected for aarch64?

@magnetophon
Copy link
Member Author

magnetophon commented Jan 5, 2018

@grahamc kind of: according to the upstream author, default optimizations are "-msse -msse2 -mfpmath=sse -ffast-math -fomit-frame-pointer -O3 -fno-finite-math-only"

For arm, he suggests: "-mcpu=cortex-a7 -mthumb -mfpu=neon-vfpv4 -mfloat-abi=hard -mvectorize-with-neon-quad -funsafe-loop-optimizations -funsafe-math-optimizations"

He also mentions: "but if this is ARM, I'm pretty sure it won't run x-run free without optimizations, some kind of compile-time vectorization is needed"

Not sure how to proceed.

One option is to do:

  makeFlags = ''
    OPTIMIZATIONS=-O3
  '';

@grahamc
Copy link
Member

grahamc commented Jan 6, 2018

Eh, we can cover it in the future :)

@grahamc grahamc merged commit ba0d6c1 into NixOS:master Jan 6, 2018
@magnetophon magnetophon deleted the setbfree branch January 6, 2018 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants