Bullet: upgrade and fix on aarch64 #33494
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build bullet |
There was a problem hiding this comment.
Failure for system: x86_64-darwin
_main in main_opengl_single_example.o
"_useShadowMap", referenced from:
GL_ShapeDrawer::drawScene(btDiscreteDynamicsWorld const*, bool, int) in GL_ShapeDrawer.o
ld: symbol(s) not found for architecture x86_64
clang-4.0: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [examples/BasicDemo/CMakeFiles/AppBasicExampleGui.dir/build.make:230: examples/BasicDemo/AppBasicExampleGui] Error 1
make[1]: *** [CMakeFiles/Makefile2:344: examples/BasicDemo/CMakeFiles/AppBasicExampleGui.dir/all] Error 2
make: *** [Makefile:141: all] Error 2
builder for ‘/nix/store/5kisf2hk2rrxr2a234z2rjqf39yc4yzk-bullet-2.87.drv’ failed with exit code 2
error: build of ‘/nix/store/5kisf2hk2rrxr2a234z2rjqf39yc4yzk-bullet-2.87.drv’ failed
There was a problem hiding this comment.
Success for system: x86_64-linux
shrinking /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87/lib/libBulletCollision.so.2.87
shrinking /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87/lib/libBulletInverseDynamicsUtils.so.2.87
shrinking /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87/lib/libHACD.so.2.87
shrinking /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87/lib/libBullet3Dynamics.so.2.87
shrinking /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87/lib/libBullet2FileLoader.so.2.87
strip is /nix/store/wxn5gn8amxm1w0ikcx4gbs8a17wvss4j-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87/lib
patching script interpreter paths in /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87
checking for references to /tmp/nix-build-bullet-2.87.drv-0 in /nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87...
/nix/store/y1dq6q65bqsva03c9g72pwlajc8rw5n6-bullet-2.87
|
The darwin failure is not introduced by this change: https://hydra.nixos.org/build/66960784 |
8 tasks
|
@aforemny any feedback? |
|
@lheckemann Looks good to me! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
New upstream version, aarch64 build was broken
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)