Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kdeconnect: Add sshfs as a dependency #33467

Merged
merged 1 commit into from Jan 12, 2018
Merged

kdeconnect: Add sshfs as a dependency #33467

merged 1 commit into from Jan 12, 2018

Conversation

nixy
Copy link
Contributor

@nixy nixy commented Jan 5, 2018 •
edited

Motivation for this change

kdeconnect depends on sshfs to mount the filesystem of android devices as discussed in #33442 and #27806

Things done

I've built this on a Linux server to test the build works, but haven't yet tested that kdeconnect works. I likely won't be able to finish testing this till Sunday night.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nixy nixy changed the title [WIP] kdeconnect: Add sshfs as a dependency kdeconnect: Add sshfs as a dependency Jan 12, 2018
@nixy
Copy link
Contributor Author

nixy commented Jan 12, 2018

@FRidh
Tested this and it worked as expected. Should be good to merge if there aren't any objections.

@FRidh FRidh merged commit 2832cc7 into NixOS:master Jan 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nixy @FRidh @GrahamcOfBorg