Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tewisay: init at git-2017-04-14 #33488

Merged
merged 2 commits into from Jan 21, 2018
Merged

tewisay: init at git-2017-04-14 #33488

merged 2 commits into from Jan 21, 2018

Conversation

Chiiruno
Copy link
Contributor

@Chiiruno Chiiruno commented Jan 5, 2018 •
edited

Motivation for this change

I like cowsay, so I wanted to add a fun alternative to this repository.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@nlewo
Copy link
Member

nlewo commented Jan 6, 2018

Tested and LGTM.

@Chiiruno
Copy link
Contributor Author

Chiiruno commented Jan 7, 2018

Is there anything I need to do for this to be merged, or is it good as it is?

nlewo
nlewo reviewed Jan 15, 2018
View reviewed changes
pkgs/tools/misc/tewisay/default.nix Outdated
{ stdenv, buildGoPackage, fetchgit, fetchhg, fetchbzr, fetchsvn }:

buildGoPackage rec {
name = "tewisay-unstable-${version}";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you remove "unstable"?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, that's good like this in fact... (https://nixos.org/nixpkgs/manual/#sec-package-naming)

@nlewo
Copy link
Member

nlewo commented Jan 16, 2018

@Mic92 LGTM. Could you have a look please?

@Mic92 Mic92 merged commit b23e92e into NixOS:master Jan 21, 2018
@Mic92
Copy link
Member

Mic92 commented Jan 21, 2018

Thanks!

@Chiiruno
Copy link
Contributor Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlewo nlewo nlewo approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Chiiruno @nlewo @Mic92 @GrahamcOfBorg @Madouura