Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sierra-shared-test: fix build #33487

Merged
merged 1 commit into from Jan 5, 2018
Merged

sierra-shared-test: fix build #33487

merged 1 commit into from Jan 5, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Jan 5, 2018

Motivation for this change

Using 500 libraries started failing with clang++: Argument list too long
This is enough to reproduce the issue.

/cc @Ericson2314

building '/nix/store/nrilbfs3sdrn45l45djrw16ghf2qsid4-macos-sierra-shared-test.drv'...
/nix/store/yss9k0xkbg44vn3wl3qzr8ybw9hs4pmx-stdenv-darwin/setup: line 1211: 19349 Abort trap: 6           bad-asdf &> /dev/null
bad-asdf should fail on sierra, OK
goo-asdf should succeed on sierra, OK
/nix/store/z5kgmw8fkgvjhpav3bk4f15rk6sfyp2z-macos-sierra-shared-test
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@LnL7
sierra-shared-test: fix build
80de99b 
Using 500 libraries started failing with clang++: Argument list too long
This is enough to reproduce the issue.
@LnL7 LnL7 added the 6.topic: darwin Running or building packages on Darwin label Jan 5, 2018
@Ericson2314 Ericson2314 merged commit 88c227f into NixOS:master Jan 5, 2018
@Ericson2314
Copy link
Member

Thanks @LnL7! Someday I'll teach CC wrapper how to stick the args back in a response file or whatever.

@LnL7 LnL7 deleted the sierra-shared-test branch January 5, 2018 23:08
@LnL7
Copy link
Member Author

LnL7 commented Jan 5, 2018

Yeah, I was wondering about that for builds with a very large number of dependencies.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 1-10 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@LnL7 @Ericson2314 @GrahamcOfBorg