Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wrapPythonPrograms: do not propagate disabling user site-packages to child-processes #33528

Merged
merged 1 commit into from Jan 7, 2018
Merged

wrapPythonPrograms: do not propagate disabling user site-packages to child-processes #33528

merged 1 commit into from Jan 7, 2018

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Jan 6, 2018

The PYTHONNOUSERSITE was exported to prevent impurities during
runtime. The downside of exporting environment variables is that they
always propagate all the way down the process tree, unless they are
explicitly unset at some point. Using the -s argument applies it only
to the process executed in the wrapper. That way, subprocesses are free
to do impure things.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@FRidh
wrapPythonPrograms: do not propagate disabling user site-packages to …
3102035 
…child-processes

The `PYTHONNOUSERSITE` was exported to prevent impurities during
runtime. The downside of exporting environment variables is that they
always propagate all the way down the process tree, unless they are
explicitly unset at some point. Using the `-s` argument applies it only
to the process executed in the wrapper. That way, subprocesses are free
to do impure things.
@FRidh FRidh mentioned this pull request Jan 6, 2018
Open
zimbatm
zimbatm approved these changes Jan 6, 2018
View reviewed changes
Copy link
Member

@zimbatm zimbatm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sounds good

@FRidh FRidh merged commit aac9c9d into NixOS:staging Jan 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zimbatm zimbatm zimbatm approved these changes

@orivej orivej orivej approved these changes

Assignees
No one assigned
Labels
0.kind: enhancement 6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@FRidh @zimbatm @orivej @vcunat @GrahamcOfBorg