Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos: introduce boot.growPartition #33521

Merged
merged 1 commit into from Jan 6, 2018
Merged

nixos: introduce boot.growPartition #33521

merged 1 commit into from Jan 6, 2018

Conversation

zimbatm
Copy link
Member

@zimbatm zimbatm commented Jan 6, 2018 •
edited

Motivation for this change

Introduce the first part of #32776. I think that PR is going to take a while.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Fits CONTRIBUTING.md.

@zimbatm zimbatm force-pushed the separate-profiles-boot-growPartition branch from c96f878 to c3f14e4 Compare January 6, 2018 13:12
@zimbatm zimbatm mentioned this pull request Jan 6, 2018
Closed
8 tasks
@zimbatm
nixos: introduce boot.growPartition
f56eceb 
Move it from being a profile
@zimbatm zimbatm force-pushed the separate-profiles-boot-growPartition branch from c3f14e4 to f56eceb Compare January 6, 2018 13:31
@zimbatm
Copy link
Member Author

zimbatm commented Jan 6, 2018

Just building nix-build nixos/release-combined.nix -A nixos.tests.ec2-nixops to validate the change.

@zimbatm zimbatm merged commit eddf30c into NixOS:master Jan 6, 2018
@zimbatm zimbatm deleted the separate-profiles-boot-growPartition branch January 6, 2018 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grahamc grahamc grahamc approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@zimbatm @grahamc @GrahamcOfBorg