nixos/acme: configurable TOS hash #33522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This hash tends to change and upstream simp_le doesn't seem to keep up with the changes.
ali-abrar
pushed a commit
to obsidiansystems/nixpkgs
that referenced
this pull request
Feb 22, 2018
This hash tends to change and upstream simp_le doesn't seem to keep up with the changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
simp_le fails with TOS hash mismatch (only for new registrations). This hash tends to change and upstream simp_le doesn't seem to keep up with the changes.
The other solution would be to use a simp_le fork since it hasn't been maintained for 6 months. I am taking this route so it can also be applied to nixos-17.09 easily.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)